Yvi's development braindump

denise

dw_suggestions

This is a bit different from what I originally had in mind.

The problem is: while we can add anchors to the page without problem, actually pointing to those anchors means modifying the URL, which therefore needs to be done before actually loading the page. Since where the from submission points to is not an attribute of the submit button, but of the form it submits (the action attribute), we would then have to have a different form with a different action for every one of the 'insert' buttons. However, that is also a nightmare as we actually *do* need to submit the whole form.

So, the last resort is leaving the page as it is, just with a way to determine where we would like out focus to be and then using JavaScript to focus on the correct anchor after loading, which is what I did here. The page without JS enabled works just like before

As kareila said in http://bugs.dwscoalition.org/show_bug.cgi?id=1284#c3 , just loading the link into the same window would open a confirm dialog saying ""Logger popup window blocked. Using confirm() instead. no data". That error comes from devel.js, which is only included on dev servers and is trying to open a window to inform you of an error, but is blocked by a pop-up blocker :)

So, why is it throwing an error saying "no data"? Well, because AJAX doesn't work that way - in the code we were making the AJAX request and then opening a new window. But AJAX is asynchronous - the window was opened before the request was finished, which is fine when opening a new window, as the old window just gets the reply and everything works. If you open the link in the same window that means you make the request, and then navigate away from the page without waiting for the reply. The request is aborted and throws an error.

But thankfully, JS allows passing of functions, so that's my solution: pass the function that's supposed to be excuted and execute it when the request was successful.