Yvi's development braindump

Yes, I am still here. And actively working on "coming back".

Fuelled in part by denise's Suggestions Hackathon, I submitted three patches for bugs that came from dw_suggestions today.

1. Bug 3487 - improve the workflow while using the poll creator, from http://dw-suggestions.dreamwidth.org/411516.html

From my Bugzilla comment:

This is a bit different from what I originally had in mind.

The problem is: while we can add anchors to the page without problem, actually pointing to those anchors means modifying the URL, which therefore needs to be done before actually loading the page. Since where the from submission points to is not an attribute of the submit button, but of the form it submits (the action attribute), we would then have to have a different form with a different action for every one of the 'insert' buttons. However, that is also a nightmare as we actually *do* need to submit the whole form.

So, the last resort is leaving the page as it is, just with a way to determine where we would like out focus to be and then using JavaScript to focus on the correct anchor after loading, which is what I did here. The page without JS enabled works just like before

2. Bug 3469 - Don't show backdated entries on Latest Things, from http://dw-suggestions.dreamwidth.org/487878.html

This was straight-forward: make a function for checking whether an entry is backdated (I can't believe this didn't already exist), then not firing the LatestPage worker when the entry is backdated. I can't actually test my solution to this in action, but it was easy enough to just test the new function, so it should work.

3. Bug 1668 - Inbox should not open links in new windows , from http://dw-suggestions.dreamwidth.org/18026.html

Wow, this one's actually from summer 2009! But I'm not surprised nobody fixed this yet - it was a bit tricky, though when I realized what happened I headdesked a bit because I run into this all the time at work. From my Bugzilla comment:

As kareila said in http://bugs.dwscoalition.org/show_bug.cgi?id=1284#c3 , just loading the link into the same window would open a confirm dialog saying ""Logger popup window blocked. Using confirm() instead. no data". That error comes from devel.js, which is only included on dev servers and is trying to open a window to inform you of an error, but is blocked by a pop-up blocker :)

So, why is it throwing an error saying "no data"? Well, because AJAX doesn't work that way - in the code we were making the AJAX request and then opening a new window. But AJAX is asynchronous - the window was opened before the request was finished, which is fine when opening a new window, as the old window just gets the reply and everything works. If you open the link in the same window that means you make the request, and then navigate away from the page without waiting for the reply. The request is aborted and throws an error.

But thankfully, JS allows passing of functions, so that's my solution: pass the function that's supposed to be excuted and execute it when the request was successful.

And yes, today was a day for Bugzilla comment novellas.

I am moved and have survived the first two weeks of my new job, so I am hoping to get re-started on Dreamwidth development over the next few days. I just assigned two simple bugs to me to get me started:

"Other accounts" should be anchored, for just adding an anchor tag on the profile page

If a user has opted out of PMs, remove "send message" from the hover menu

After that, I want to resubmit Add non-existent interest from interest search, where I am waiting on some clearifications, and do the comment part of "random userpic" option on comments & posts. Once that is out of the way, I will hopefully feel motivated to finish Private Message a Community to Contact Its Moderators .

And then, finally, sometimes towards the end of August /start of September I suspect, when I am more settled into work, I want to start on the memories overhaul. I'll need mark for parts of that, so I'll have to wait until he's back from OSCON anyway.

During the work on the memories thing I'll be picking up other things anyway, but I want to really focus on one big thing for a while. I think that will be fun, though probably also brain-wrecking :D

I'll also probably need some cheerleaders, so I hope you'll be doing that :)

I could probably use this again, huh?

Well, I haven't been doing much dev stuff lately because of job applications and so on. The past two days, I have done work on two bugs.

http://bugs.dwscoalition.org/show_bug.cgi?id=2012 use a tag list not a tag cloud on the subscription filter interface

That one I really wanted to get done Friday. I had it review- once and implemented fu's idea about using a span tag around the links and tag usage counts, which worked nicely, but this resulted in the tag box not using a variable height anymore ^^ Instead the height is now constant and the tag list overflows the box. And I have no idea how to fix this. I looked into every CSS file I could to see if that was the problem, but no results so far.

http://bugs.dwscoalition.org/show_bug.cgi?id=2474 Add non-existent interest from interest search

This is something I suggested a few months back. The problem with this is that the code to add a single interest already exists - but the code needs an interest ID, which a non-existant interest of course doesn't have. I then already had an idea of how to implement it - implement a function for creating an interest id and then adding the interest normally. So yesterday I finally did that and, inspired b< kareila I also did some mild code-cleanup. There was one portion of the SQL that was already in the code I didn't quite understand, but for the moment I just left it in. I suppose it's another failsafe for not adding an interest into the global table twice.

As an aside: there are two interests tables: one for communities and one for users. Interesting.

I had to change a translation string and decided to instead of using a "click here" link to add the interest make the link descriptive, so the link nor says "add it to your profile". I think I read about this being a nice accessibility-feature somewhere, that links are at least as descriptive as possible instead of just being "here" or "click".

While testing this, I noticed another somewhat related thing and opened this bug: http://bugs.dwscoalition.org/show_bug.cgi?id=2744 interest search needs warning/explanation if interest is too long . I didn't want to fix it directly because it isn't really in the scope of "my" bug, but it is related, because if you have a really long interest and search for it, it of course doesn't exist. If you then do a one-click add, the interest gets truncated and you add a 'wrong' interest. So the search should warn you that the interest is too long and instead of "$longinterest" it searched for "$shortinterest" and then use "$shortinterest" for the rest of the page.

Private Message a Community to Contact Its Moderators

http://dw-suggestions.dreamwidth.org/245126.html
http://bugs.dwscoalition.org/show_bug.cgi?id=2365

1: community inbox

* community inbox for messages sent directly to comm only (no other stuff)

* setting on community edit profile?

* "work as" on inbox page

* replying?

2: message forwarding

* message forwarding to admins: user-specific (not comm?!) setting - where?

* messages get forwarded to admins, if message forwarding is set, regardless of user message setting?

* forwarding setting defaults to usual user message setting

Resubmitted:

* http://bugs.dwscoalition.org/show_bug.cgi?id=2372 "Add "All Circle Members" to Circle Gifts"

Accepted:

* http://bugs.dwscoalition.org/show_bug.cgi?id=2372 "Add "All Circle Members" to Circle Gifts" (pending commit)

* http://bugs.dwscoalition.org/show_bug.cgi?id=2132 "icon overlap on colorside comment pages"

Resubmitted:

* http://bugs.dwscoalition.org/show_bug.cgi?id=2175 "add links to entry pages in the page summary module"

* http://bugs.dwscoalition.org/show_bug.cgi?id=1365 "Add support for merging tags"

Accepted:

* http://bugs.dwscoalition.org/show_bug.cgi?id=2175 "add links to entry pages in the page summary module"

* http://bugs.dwscoalition.org/show_bug.cgi?id=2475 "List subscribers on feed profile pages"