yvi: (Dreamwidth - Badass Dreamwidth dev)
[personal profile] yvi posting in [community profile] yvi_dev
I could probably use this again, huh?

Well, I haven't been doing much dev stuff lately because of job applications and so on. The past two days, I have done work on two bugs.

http://bugs.dwscoalition.org/show_bug.cgi?id=2012 use a tag list not a tag cloud on the subscription filter interface

That one I really wanted to get done Friday. I had it review- once and implemented [personal profile] fu's idea about using a span tag around the links and tag usage counts, which worked nicely, but this resulted in the tag box not using a variable height anymore ^^ Instead the height is now constant and the tag list overflows the box. And I have no idea how to fix this. I looked into every CSS file I could to see if that was the problem, but no results so far.

http://bugs.dwscoalition.org/show_bug.cgi?id=2474 Add non-existent interest from interest search

This is something I suggested a few months back. The problem with this is that the code to add a single interest already exists - but the code needs an interest ID, which a non-existant interest of course doesn't have. I then already had an idea of how to implement it - implement a function for creating an interest id and then adding the interest normally. So yesterday I finally did that and, inspired b< [personal profile] kareila I also did some mild code-cleanup. There was one portion of the SQL that was already in the code I didn't quite understand, but for the moment I just left it in. I suppose it's another failsafe for not adding an interest into the global table twice.

As an aside: there are two interests tables: one for communities and one for users. Interesting.

I had to change a translation string and decided to instead of using a "click here" link to add the interest make the link descriptive, so the link nor says "add it to your profile". I think I read about this being a nice accessibility-feature somewhere, that links are at least as descriptive as possible instead of just being "here" or "click".

While testing this, I noticed another somewhat related thing and opened this bug: http://bugs.dwscoalition.org/show_bug.cgi?id=2744 interest search needs warning/explanation if interest is too long . I didn't want to fix it directly because it isn't really in the scope of "my" bug, but it is related, because if you have a really long interest and search for it, it of course doesn't exist. If you then do a one-click add, the interest gets truncated and you add a 'wrong' interest. So the search should warn you that the interest is too long and instead of "$longinterest" it searched for "$shortinterest" and then use "$shortinterest" for the rest of the page.

Date: 2010-06-27 05:04 pm (UTC)
kareila: "PERL!" (perl)
From: [personal profile] kareila
The problem with this is that the code to add a single interest already exists - but the code needs an interest ID, which a non-existant interest of course doesn't have.

Oh, oh, but we migrated interests to sitekeywords in bug 1776 for the name=>id mapping, so wouldn't get_sitekeyword_id do that for you?

I probably should have documented that better, sorry!

Date: 2010-06-27 09:05 pm (UTC)
kareila: "Mom, I'm hungry." "Hush, I'm coding. You ate yesterday." (coding)
From: [personal profile] kareila
When you said implement a function for creating an interest id I thought that meant you were writing a different function for doing what get_sitekeyword_id already did!

I should just go review your patch! I am hip deep in my own code at the moment, though!

Date: 2010-06-29 08:16 am (UTC)
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
From: [personal profile] afuna
Hmmm. OH re: that first one, can you try adding a space before or after each of the span tags you inserted? It's possible that it might be concatenating them into one big word...

Date: 2010-06-29 06:39 pm (UTC)
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
From: [personal profile] afuna
Ehehehe. Yeah, it's an unintuitive issue to run into.

Profile

Yvi's development braindump

February 2011

S M T W T F S
  12345
6789101112
13141516171819
20212223242526
2728     

Most Popular Tags

Style Credit

Expand Cut Tags

No cut tags
Page generated Sep. 25th, 2017 01:30 pm
Powered by Dreamwidth Studios